Skip to content

[FIX] fh range should begin at 1; dependencies #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[FIX] fh range should begin at 1; dependencies #1

wants to merge 5 commits into from

Conversation

@mabuimo
Copy link

@mabuimo mabuimo commented Jul 10, 2025

What does this implement/fix?

  • The range for the fh argument should begin at 1, as 0 would include the last point of the training dataset in the cross-validation.
  • Added uv as an optional dependency manager.
  • The dependencies of requirements.txt were incomplete.

mabuimo added 2 commits July 10, 2025 19:44
@mabuimo
fix: fh range starts in 0
865fa5e 
fix: if the range starts in 0 it will include the last point of the training set
@mabuimo
fix: dependencies
ee60d0d 
I added `uv` as an alternative for dependency management. The dependencies from requirements.txt were incomplete. The whole list can be found in the .toml.
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@mabuimo mabuimo mentioned this pull request Jul 11, 2025
Open
benHeid
benHeid requested changes Jul 18, 2025
View reviewed changes
Copy link
Collaborator

@benHeid benHeid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I have a small suggestion to the code. The only major comment is could you try to rerun notebook 3. It doesn't run completely.

notebooks/03_benchmarking_forecasters.ipynb
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you execute this notebook again and check that Moirai_small runs. The following cell seems to fail

results = benchmark.run("energy_benchmarking.json", force_rerun =True)

notebooks/energy_benchmarking.json
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am unsure, do you think it is useful to push the result file?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably it is not very useful, we can remove it.

@mabuimo @benHeid
Update .gitignore
d2dd938 
Co-authored-by: Benedikt Heidrich <[email protected]>
@mabuimo
Copy link
Author

mabuimo commented Jul 18, 2025

Regarding the lock file, I found this discussion astral-sh/uv#10730 but I agree with you that we don't need to include it.

@mabuimo
Copy link
Author

mabuimo commented Jul 18, 2025 •
edited
Loading

Btw @benHeid testing TimeLLMForecast fails with the example of notebook 3.

Code to add to replicate the issue:

from sktime.forecasting.time_llm import TimeLLMForecaster
 benchmark.add_estimator(
     TimeLLMForecaster()
 )

@mabuimo
Copy link
Author

mabuimo commented Jul 18, 2025

@benHeid ready for final review. All comments addressed, thank you.

fkiraly
fkiraly requested changes Aug 2, 2025
View reviewed changes
Copy link

@fkiraly fkiraly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

(@benHeid is currently off sktime, so I am reviewing)

Could you kindly do a clean re-execution of the notebooks? I.e., reset and execute all of them.

@mabuimo
Copy link
Author

mabuimo commented Aug 4, 2025

Hi @fkiraly in theory the last PR includes a full re-run of all cells. Isn't that the case? Thanks.

@fkiraly
Copy link

fkiraly commented Aug 14, 2025

I think you need to reset the notebook and then re-execute - if the first cell shows execution number 82 and not 1, it has not been reset properly

@mabuimo
Rerun notebooks
63b5b63 
benchmark.run still fails (!)
@mabuimo
Copy link
Author

mabuimo commented Oct 18, 2025 •
edited
Loading

@fkiraly I rerun the notebooks. 01, 02, and 04 notebooks are ok. 03 still fails in the benchmarking module, FYI @jgyasu

RuntimeError: The size of tensor a (71) must match the size of tensor b (70) at non-singleton dimension 3

@fkiraly
Copy link

fkiraly commented Oct 24, 2025

I recommend to open an issue on sktime with minimum reproducible code on the remaining issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fkiraly fkiraly fkiraly requested changes

@benHeid benHeid benHeid requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mabuimo @fkiraly @benHeid